chore(tier4_perception_launch): enable to use argument centerpoint_model_name
#1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MasatoSaeki <[email protected]>
github-actions
bot
added
the
component:perception
Signed-off-by: MasatoSaeki <[email protected]>
technolojin
reviewed
Oct 3, 2024
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
YoshiRi
approved these changes
Oct 23, 2024
| @@ -19,12 +19,13 @@ | |||
| <arg name="detected_objects_filter_method" default="lanelet_filter" description="options: lanelet_filter, position_filter"/> | |||
| <arg name="detected_objects_validation_method" default="obstacle_pointcloud" description="options: obstacle_pointcloud, occupancy_grid (must be used with laserscan_based_occupancy_grid_map)"/> | |||
| <arg name="data_path" default="$(env HOME)/autoware_data" description="packages data and artifacts directory path"/> | |||
| <arg name="lidar_detection_model" default="centerpoint" description="options: `transfusion`, `centerpoint`, `apollo`, `pointpainting`, `clustering`"/> | |||
| <arg name="lidar_detection_model" default="centerpoint" description="specify lidar detection model type and optionally can add model name like `centerpoint/centerpoint_sigma`"/> | |||
There was a problem hiding this comment.
I prefer to add following statement.
"If the model name is not declared, the default model in lidar_dnn_detector.launch.xml will be used. "
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enable to use argument
centerpoint_model_name.This PR need to merge following universe PR at same time.
centerpoint_model_namefrom autoware_launch autoware.universe#9003Tests performed
I have checked it work correctory by sample rosbag in my local pc.
And also checked whether it can change model. (A part of model is failed but it is no problem because it depend on another repos.)
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.