Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): added ros2_spconv #5658

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link

@knzo25 knzo25 commented Jan 15, 2025

Description

Temporarily adds https://github.com/knzo25/ros2_spconv
to the autoware.repos file to test compilation times

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added the tag:run-health-check Run health-check label Jan 15, 2025
@xmfcx
Copy link
Contributor

xmfcx commented Jan 15, 2025

It failed without CUDA. Default behavior in Autoware packages is to skip building the CUDA packages yet report success for build 🤷 (like in autoware_lidar_centerpoint/CMakeLists.txt)

@knzo25
Copy link
Author

knzo25 commented Jan 15, 2025

@xmfcx
In this case, it seems to be because the second line of the cmakelist uses project(spconvlib LANGUAGES CXX CUDA).
By selecting it as a language, the rest of the cmake commands act different, which was needed to port the original cmake without many changes. I will try to find a way that does not make to much changes on the autogenerated code yet it is compliant with our way to do things 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants