-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware_
prefix for diagnostic_graph_utils
#9968
base: main
Are you sure you want to change the base?
feat: apply autoware_
prefix for diagnostic_graph_utils
#9968
Conversation
Note: * In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki <[email protected]>
* Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <[email protected]>
* To follow the previous commit Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9968 +/- ##
==========================================
- Coverage 29.46% 29.40% -0.06%
==========================================
Files 1444 1450 +6
Lines 108703 108922 +219
Branches 42492 42529 +37
==========================================
Hits 32031 32031
- Misses 73582 73801 +219
Partials 3090 3090
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
This PR is tested with the
autoware_internal_msgs
with1.4.0
due to the following error I observedCurrently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Directory Name
autoware_
as a prefix to the directory name.packages.xml
autoware_
to thename
element.CMakeLists.txt
project
name toautoware_***
.autoware::
toPLUGIN
.Header Files (.hpp)
#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.Source Files (.cpp)
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.Launch Files
autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.Include
autoware
folder as necessary and update include statements accordingly.Verification Points
find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
diagnostic_graph_utils
needs to modify their code. This is maybe kind of non quick-win task.