Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_kalman_filter): move autoware_kalman_filter to autowar.core #9872

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat(autoware_kalman_filter): move autoware_kalman_filter to autowar.core #9872

merged 1 commit into from
Jan 15, 2025

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Jan 9, 2025

Description

We are porting autoware_kalman_filter to autoware.core, and this PR removes the package from autoware.universe.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@cyn-liu cyn-liu requested a review from youtalk January 9, 2025 02:01
@cyn-liu cyn-liu added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) labels Jan 9, 2025
@cyn-liu cyn-liu mentioned this pull request Jan 9, 2025
Open
22 tasks
youtalk
youtalk approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyn-liu cyn-liu mentioned this pull request Jan 11, 2025
Merged
@mitsudome-r
Copy link
Member

I have confirmed that differences with autowarefoundation/autoware.core#141 are:

  • version reset for package.xml and CHANGELOG.rst
  • README

@mitsudome-r mitsudome-r merged commit a6b5f3c into autowarefoundation:main Jan 15, 2025
39 of 40 checks passed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Jan 15, 2025
@cyn-liu @esteve
feat(autoware_kalman_filter): move autoware_kalman_filter to autowar.…
1831097 
…core (autowarefoundation#9872)

feat(autoware_kalman_filter): move autoware_kalman_filter to autoware.core

Signed-off-by: liu cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk approved these changes

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@IshitaTakeshi IshitaTakeshi Awaiting requested review from IshitaTakeshi IshitaTakeshi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Software Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyn-liu @mitsudome-r @youtalk