feat(lidar_centerpoint, pointpainting)!: move max_voxel_count from _ml_package.param.yaml #9578
+17
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
max_voxel_count
is likely to be tuned for each vehicle / environment, I would like to move this parameter from*_ml_package.param.yaml
to*.param.yaml
.Related links
Must be merged with autowarefoundation/autoware_launch#1258
How was this PR tested?
Works for centerpoint
Works for pointpainting
Notes for reviewers
None.
Interface changes
Modifications
model_params.max_voxel_count
max_voxel_count
To TIER IV members:
This PR will be a breaking change for ML models. Please contact the perception team in TIER IV for a proper update of ML models in Web.Auto.
For pointpainting, please use this model: https://evaluation.tier4.jp/evaluation/mlpackages/5b56c824-de65-406e-b12f-d7271589cc70/releases/cfe1a125-84d0-42b2-845c-c03efe896d3e?project_id=zWhWRzei&tab=reports
For centerpoint, please use
base/2.0
and the latter versionEffects on system behavior
None.