-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cuda_utils): move cuda_utils to sensing #8729
refactor(cuda_utils): move cuda_utils to sensing #8729
Conversation
Signed-off-by: yoshiri <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I will send a PR to add me as a maintainer instead of Nishimatsu-san later)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8729 +/- ##
==========================================
- Coverage 25.04% 25.01% -0.03%
==========================================
Files 1318 1318
Lines 97944 97954 +10
Branches 37807 37816 +9
==========================================
- Hits 24531 24505 -26
- Misses 70925 70979 +54
+ Partials 2488 2470 -18
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note: this cuda_utils
package is currently used in sensing/perception packagesonly; so we move this package into the sensing package to mitigate dependencies in autoware.universe. Once other packages, such as planning, will start to consider CUDA implementation, we'll move this package into common
again.
…8729) fix: move cuda_utils to sensing Signed-off-by: yoshiri <[email protected]>
Description
According to #8695, we want to move cuda_utils from common packages to sensing.
This PR assumes that only perception and sensing are going to use cuda_utils.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.