Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cuda_utils): move cuda_utils to sensing #8729

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Sep 3, 2024

Description

According to #8695, we want to move cuda_utils from common packages to sensing.

This PR assumes that only perception and sensing are going to use cuda_utils.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@YoshiRi YoshiRi requested review from wep21 and manato as code owners September 3, 2024 06:15
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YoshiRi YoshiRi requested a review from knzo25 September 3, 2024 06:15
@YoshiRi YoshiRi changed the title fix(cuda_utils): move cuda_utils to sensing refactor(cuda_utils): move cuda_utils to sensing Sep 3, 2024
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I will send a PR to add me as a maintainer instead of Nishimatsu-san later)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.01%. Comparing base (fcad0fb) to head (f5626af).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8729      +/-   ##
==========================================
- Coverage   25.04%   25.01%   -0.03%     
==========================================
  Files        1318     1318              
  Lines       97944    97954      +10     
  Branches    37807    37816       +9     
==========================================
- Hits        24531    24505      -26     
- Misses      70925    70979      +54     
+ Partials     2488     2470      -18     
Flag Coverage Δ *Carryforward flag
differential 6.14% <ø> (?)
total 25.01% <ø> (-0.03%) ⬇️ Carriedforward from 03f675e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi YoshiRi enabled auto-merge (squash) September 3, 2024 06:36
Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note: this cuda_utils package is currently used in sensing/perception packagesonly; so we move this package into the sensing package to mitigate dependencies in autoware.universe. Once other packages, such as planning, will start to consider CUDA implementation, we'll move this package into common again.

@YoshiRi YoshiRi merged commit b967b6f into autowarefoundation:main Sep 3, 2024
45 checks passed
@YoshiRi YoshiRi deleted the refactor/move_cuda_utils_to_sensing branch September 3, 2024 13:11
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants