Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes #8672

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes #8672

wants to merge 1 commit into from
+81 −1

Conversation

beyzanurkaya
Copy link
Contributor

@beyzanurkaya beyzanurkaya commented Aug 29, 2024 •
edited by brkay54
Loading

Description

Fixes: #7923

Scenarios should be passed:

  • UC-NTR-004-0001
  • UC-VRU-002-0005

Related links

Must merge: autowarefoundation/autoware_launch#1149

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@beyzanurkaya beyzanurkaya added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 29, 2024
@beyzanurkaya beyzanurkaya self-assigned this Aug 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@beyzanurkaya beyzanurkaya force-pushed the fix-bpp branch 4 times, most recently from d890466 to 60c1b1e Compare September 3, 2024 07:40
@beyzanurkaya
Copy link
Contributor Author

2024-09-03.15-55-15.mp4

@beyzanurkaya beyzanurkaya mentioned this pull request Sep 3, 2024
Draft
4 tasks
@beyzanurkaya beyzanurkaya changed the title fix(autoware_behavior_path_planner): shift path according to traffic flow fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes Sep 3, 2024
@beyzanurkaya beyzanurkaya force-pushed the fix-bpp branch 10 times, most recently from 9951cc6 to f370eef Compare September 3, 2024 14:29
@beyzanurkaya beyzanurkaya added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
@beyzanurkaya beyzanurkaya force-pushed the fix-bpp branch 4 times, most recently from bac0637 to 1bd80c1 Compare September 4, 2024 14:26
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes missing coverage. Please review.

Project coverage is 26.15%. Comparing base (6fccdf5) to head (d8e8425).
Report is 835 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_planner/src/behavior_path_planner_node.cpp 24.13% 21 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8672      +/-   ##
==========================================
- Coverage   26.17%   26.15%   -0.03%     
==========================================
  Files        1298     1305       +7     
  Lines       96978    97055      +77     
  Branches    39174    39196      +22     
==========================================
- Hits        25383    25382       -1     
- Misses      68968    69043      +75     
- Partials     2627     2630       +3
Flag Coverage Δ *Carryforward flag
differential 15.46% <29.03%> (?)
total 26.16% <ø> (-0.02%) ⬇️ Carriedforward from 6fccdf5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beyzanurkaya beyzanurkaya force-pushed the fix-bpp branch 3 times, most recently from 66e65db to c06c0ba Compare September 9, 2024 07:58
@beyzanurkaya beyzanurkaya force-pushed the fix-bpp branch 3 times, most recently from addc642 to 2e5d420 Compare September 9, 2024 10:07
brkay54 pushed a commit that referenced this pull request Sep 9, 2024
shift path according to traffic flow if lanes is bidirectional
1e87380 
#8672
@xmfcx
Copy link
Contributor

xmfcx commented Nov 26, 2024

@beyzanurkaya what is the status of this PR? Is this ready to be merged, if not, what else should be done on this PR?

@stale Stale
Copy link

stale bot commented Jan 25, 2025

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkquda mkquda Awaiting requested review from mkquda mkquda will be requested when the pull request is marked ready for review mkquda is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran will be requested when the pull request is marked ready for review danielsanchezaran is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 will be requested when the pull request is marked ready for review rej55 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori will be requested when the pull request is marked ready for review go-sakayori is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 will be requested when the pull request is marked ready for review kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin will be requested when the pull request is marked ready for review soblin is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem will be requested when the pull request is marked ready for review maxime-clem is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota will be requested when the pull request is marked ready for review satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk will be requested when the pull request is marked ready for review shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe will be requested when the pull request is marked ready for review TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 will be requested when the pull request is marked ready for review takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 will be requested when the pull request is marked ready for review tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 will be requested when the pull request is marked ready for review zulfaqar-azmi-t4 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara will be requested when the pull request is marked ready for review kyoichi-sugahara is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo will be requested when the pull request is marked ready for review TomohitoAndo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@beyzanurkaya beyzanurkaya

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Milestone
No milestone
2 participants
@beyzanurkaya @xmfcx