Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(route_handler): add unit test for lane change related functions #7504

Merged
merged 3 commits into from
Jun 24, 2024
Merged

feat(route_handler): add unit test for lane change related functions #7504

merged 3 commits into from
Jun 24, 2024

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Add unit test for lane change related function.
Also fix setMap to be able to get local coordinate properly.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jun 17, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-6230-create-unit-test-for-route-handler-functions-that-are-used-by-lane-change-module branch from ef4a1d3 to 0279d6d Compare June 19, 2024 08:11
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.23967% with 59 lines in your changes missing coverage. Please review.

Project coverage is 23.47%. Comparing base (507e3f4) to head (0279d6d).
Report is 95 commits behind head on main.

❗ Current head 0279d6d differs from pull request most recent head 819f137

Please upload reports for the commit 819f137 to get more accurate results.

Files Patch % Lines
...autoware_route_handler/test/test_route_handler.cpp 46.93% 9 Missing and 43 partials ⚠️
...on/autoware_test_utils/src/autoware_test_utils.cpp 41.66% 2 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7504      +/-   ##
==========================================
+ Coverage   14.84%   23.47%   +8.63%     
==========================================
  Files        1999      616    -1383     
  Lines      139163    56688   -82475     
  Branches    43716    22082   -21634     
==========================================
- Hits        20661    13310    -7351     
+ Misses      95731    41343   -54388     
+ Partials    22771     2035   -20736
Flag Coverage Δ
differential 23.47% <51.23%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkquda
mkquda approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@mkquda mkquda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-6230-create-unit-test-for-route-handler-functions-that-are-used-by-lane-change-module branch from 0279d6d to 9472755 Compare June 21, 2024 08:14
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 21, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-6230-create-unit-test-for-route-handler-functions-that-are-used-by-lane-change-module branch from 9472755 to 926ef72 Compare June 21, 2024 08:17
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-6230-create-unit-test-for-route-handler-functions-that-are-used-by-lane-change-module branch from 926ef72 to 819f137 Compare June 21, 2024 08:18
@github-actions github-actions bot removed the component:system System design and integration. (auto-assigned) label Jun 21, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) June 21, 2024 08:27
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 480d97a into autowarefoundation:main Jun 24, 2024
24 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the RT1-6230-create-unit-test-for-route-handler-functions-that-are-used-by-lane-change-module branch June 24, 2024 00:57
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
@zulfaqar-azmi-t4 @simon-eisenmann-driveblocks
feat(route_handler): add unit test for lane change related functions (a…
2d53e22 
…utowarefoundation#7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@zulfaqar-azmi-t4 @tby-udel
feat(route_handler): add unit test for lane change related functions (a…
73ea844 
…utowarefoundation#7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@zulfaqar-azmi-t4 @KhalilSelyan
feat(route_handler): add unit test for lane change related functions (#…
ebee6d8 
…7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Aug 1, 2024
@zulfaqar-azmi-t4
feat(route_handler): add unit test for lane change related functions (a…
7ae42bc 
…utowarefoundation#7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Aug 6, 2024
@zulfaqar-azmi-t4
feat(route_handler): add unit test for lane change related functions (a…
5655742 
…utowarefoundation#7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2024
@zulfaqar-azmi-t4
feat(route_handler): add unit test for lane change related functions (a…
ccd4ffb 
…utowarefoundation#7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Aug 15, 2024
@zulfaqar-azmi-t4 @saka1-s
feat(route_handler): add unit test for lane change related functions (a…
cf3ed3b 
…utowarefoundation#7504)

* RT1-6230 feat(route_handler): add unit test for lane change related functions

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spell check

Signed-off-by: Zulfaqar Azmi <[email protected]>

* fix spellcheck

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@soblin soblin soblin approved these changes

@mkquda mkquda mkquda approved these changes

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zulfaqar-azmi-t4 @rej55 @soblin @mkquda