Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manual_controller): set PARK gear when going from reverse to drive #6230

Merged

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jan 30, 2024

Description

Fix #5427

  • Force gear to PARK when going from reverse to drive (we were already forcing it to PARK when going from drive to reverse).
  • Read acceleration from topic instead of calculating it in the node.

Tests performed

Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jan 30, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 14.40%. Comparing base (833722b) to head (332e084).
Report is 1 commits behind head on main.

❗ Current head 332e084 differs from pull request most recent head b3d0f71. Consider uploading reports for the commit b3d0f71 to get more accurate results

Files Patch % Lines
...ontrol_rviz_plugin/src/tools/manual_controller.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6230      +/-   ##
==========================================
- Coverage   15.19%   14.40%   -0.80%     
==========================================
  Files        1851     1906      +55     
  Lines      128449   129832    +1383     
  Branches    39228    37571    -1657     
==========================================
- Hits        19519    18697     -822     
- Misses      87138    90140    +3002     
+ Partials    21792    20995     -797     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.40% <ø> (-0.80%) ⬇️ Carriedforward from 47f265d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem enabled auto-merge (squash) March 4, 2024 05:31
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem merged commit 065068b into autowarefoundation:main Mar 4, 2024
20 checks passed
@maxime-clem maxime-clem deleted the fix/manual_controller-reverse branch March 6, 2024 01:33
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behaviors while using rviz ManualController plugin
3 participants