-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manual_controller): set PARK gear when going from reverse to drive #6230
fix(manual_controller): set PARK gear when going from reverse to drive #6230
Conversation
Signed-off-by: Maxime CLEMENT <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6230 +/- ##
==========================================
- Coverage 15.19% 14.40% -0.80%
==========================================
Files 1851 1906 +55
Lines 128449 129832 +1383
Branches 39228 37571 -1657
==========================================
- Hits 19519 18697 -822
- Misses 87138 90140 +3002
+ Partials 21792 20995 -797
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#6230) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
autowarefoundation#6230) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: kaigohirao <[email protected]>
autowarefoundation#6230) Signed-off-by: Maxime CLEMENT <[email protected]>
Description
Fix #5427
Tests performed
Psim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.