Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): removed tf2_listener_module #6008

Removed tf2_listener_module

28c57e6
Select commit
Loading
Failed to load commit list.
Merged

refactor(ndt_scan_matcher): removed tf2_listener_module #6008

Removed tf2_listener_module
28c57e6
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 4, 2024 in 34s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method ndt_scan_matcher_core.cpp: is_activated_

Annotations

Check notice on line 266 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method

is_activated_ decreases from 168 to 167 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.