Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): resample path interval for lane departure check accuracy #10058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 31, 2025

Description

currently the parking path point interval for lane departure check is center_line_path_interval: 1.0
depending on resampled points sometimes departure can not be detected especialy cureve lane.

(footrpint in this image is not the exact path used for lane departure check. this is behavior path output.)

image

this is just workaround but in this PR, resample path interval for lane departure check accuracy.

todo: Implement lane departure detection that does not depend on the footprint

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

https://evaluation.tier4.jp/evaluation/reports/42174ff9-bc20-5342-9ab9-e35eb3b0e751?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 31, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.84%. Comparing base (461dbc1) to head (3a2dd14).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 4 Missing ⚠️
...dule/src/pull_over_planner/geometric_pull_over.cpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10058      +/-   ##
==========================================
- Coverage   29.21%   28.84%   -0.38%     
==========================================
  Files        1439     1445       +6     
  Lines      108115   109122    +1007     
  Branches    42638    43178     +540     
==========================================
- Hits        31588    31477     -111     
- Misses      73485    74553    +1068     
- Partials     3042     3092      +50     
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 29.15% <0.00%> (-0.07%) ⬇️ Carriedforward from 461dbc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants