Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(path_generator): add path_generator package #138

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mitukou1109
Copy link

Description

This PR adds path_generator package, a simplified alternative of behavior_path_planner.

Related links

How was this PR tested?

Psim on a lanelet2 map with waypoints

Screencast.from.2024.11.29.16.11.24.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it’s a porting task, I’m keeping the review to a minimum.

planning/autoware_path_generator/package.xml Outdated Show resolved Hide resolved
planning/autoware_path_generator/src/node.hpp Show resolved Hide resolved
planning/autoware_path_generator/src/node.hpp Show resolved Hide resolved
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your revision. LGTM

@youtalk youtalk enabled auto-merge (squash) January 9, 2025 12:58
@kosuke55
Copy link

@takayuki5168
CI failed

updated cache in /github/home/.ros/rosdep/sources.cache
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
autoware_path_generator: Cannot locate rosdep definition for [tier4_planning_msgs]

can we use tier4 msgs in core?

@takayuki5168
Copy link

@kosuke55
In principle, we cannot use tier4's msgs in autoware.core.
The CI failure is fine for now since the AWE team is working on porting some of tier4's msgs to autoware's msgs in parallel.

@youtalk youtalk disabled auto-merge January 14, 2025 06:03
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PathWithLaneId has been ported. Please use it instead.
autowarefoundation/autoware_internal_msgs#42

<depend>generate_parameter_library</depend>
<depend>rclcpp</depend>
<depend>rclcpp_components</depend>
<depend>tier4_planning_msgs</depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<depend>tier4_planning_msgs</depend>
<depend>autoware_internal_planning_msgs</depend>

Please make the same changes to the other sections as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants