Test fixes

autometrics-dev · Dec 5, 2023 · 116112a · 116112a
1 parent f13c662
commit 116112a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/autometrics/src/exporter-prometheus/PrometheusExporter.ts b/packages/autometrics/src/exporter-prometheus/PrometheusExporter.ts
@@ -42,6 +42,7 @@ export interface ExporterConfig {
 
 export class PrometheusExporter extends MetricReader {
   private readonly _abortController: AbortController;
+  private readonly _server: Deno.HttpServer;
 
   // This will be required when histogram is implemented. Leaving here so it is not forgotten
   // Histogram cannot have a attribute named 'le'
@@ -68,7 +69,7 @@ export class PrometheusExporter extends MetricReader {
     this._abortController = new AbortController();
     const { signal } = this._abortController;
 
-    Deno.serve({ hostname, port, signal, onError }, async (request) => {
+    this._server = Deno.serve({ hostname, port, signal, onError }, async (request) => {
       if (new URL(request.url).pathname !== "/metrics") {
         return new Response("not found", { status: 404 });
       }
@@ -113,6 +114,6 @@ export class PrometheusExporter extends MetricReader {
    */
   stopServer(): Promise<void> {
     this._abortController.abort();
-    return Promise.resolve();
+    return this._server.finished;
   }
 }
diff --git a/packages/autometrics/tests/otlpHttpExporter.test.ts b/packages/autometrics/tests/otlpHttpExporter.test.ts
@@ -14,7 +14,7 @@ Deno.test("OTLP/HTTP exporter", async (t) => {
   // retrying, which may mess with other tests.
   const serverController = new AbortController();
   const { signal } = serverController;
-  Deno.serve({ port, signal }, () => new Response("ok"));
+  const server = Deno.serve({ port, signal }, () => new Response("ok"));
 
   // make sure that metrics that are collected before `init()` is called are
   // correctly tracked.
@@ -53,4 +53,6 @@ Deno.test("OTLP/HTTP exporter", async (t) => {
   );
 
   serverController.abort();
+
+  await server.finished;
 });
diff --git a/packages/autometrics/tests/testUtils.ts b/packages/autometrics/tests/testUtils.ts
@@ -59,7 +59,7 @@ export function testWithTemporality({
     // retrying, which may mess with other tests.
     const serverController = new AbortController();
     const { signal } = serverController;
-    Deno.serve({ port, signal }, () => new Response("ok"));
+    const server = Deno.serve({ port, signal }, () => new Response("ok"));
 
     const timeout = 10;
 
@@ -96,5 +96,7 @@ export function testWithTemporality({
     await metricReader.shutdown();
 
     serverController.abort();
+
+    await server.finished;
   };
 }