-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update license automation #522
Conversation
@dmah42 do me a favor and don't add a merge commit if the need comes up |
i feel like these three commits can be merged without losing any useful information, and given they fix issues with the first commit maybe a merge is appropriate? :) |
do you mean squash or merge? |
I don't know... whatever GitHub does... probably squash. were you asking me not to hit the "update branch" button or not to squash on merge? |
I can't see what is causing the failure here. feels like generated code is linting badly. maybe we suppress the lint check? |
Is it ok to keep the small commits and rebase them over main? I am going to be removing an amount of things in my fork and doing things in small commits helps me maintain parity with upstream If not, no worries, let's just get this merged and I'll figure it out after edit: after fiddling with my setup, I can make sure my pr's are squashed to a single commit in the future, sorry for the inconvenience |
1a12236
to
ced6c32
Compare
ced6c32
to
ab570b3
Compare
ab570b3
to
cc1d700
Compare
i think rebasing this onto the base branch should resolve the issues. |
cc1d700
to
4a8babb
Compare
Update automation scripts for adding license headers to files. Also shortens the length of the headers to take up less lines in each file. Moving forward, when you add new files, simply run `make headers` before submitting your pull request. You can also manually run `DRY_RUN=1 ./hack/headers-write` from the root of the repo to get a list of the changes that `make headers` is going to perform
4a8babb
to
700773d
Compare
woo! |
Update automation scripts for adding license headers to files. Also shortens the length of the headers to take up less lines in each file.
Moving forward, when you add new files, simply run
make headers
before submitting your pull request. You can also manually runDRY_RUN=1 ./hack/headers-write
from the root of the repo to get a list of the changes thatmake headers
is going to performcloses #468