Few fixes that allow auraed to run as true PID 1 #447
Conversation
JeroenSoeters
force-pushed
the
true-pid-1
branch
from
0611757 to
33ddc62
Compare
| @@ -87,9 +87,6 @@ impl SystemRuntime for Pid1SystemRuntime { | |||
| // TODO We likely to do not need to mount these filesystems. | |||
| // TODO Do we want to have a way to "try" these mounts and continue without erroring? | |||
|
|
|||
| MountSpec { source: None, target: "/dev", fstype: Some("devtmpfs") } | |||
| .mount()?; | |||
There was a problem hiding this comment.
This was throwing a "Resource busy" so I presumed this wasn't actually needed?
There was a problem hiding this comment.
Is it just a feature of cloud-hypervisor that /dev is already mounted, but we would need to mount it in a non-vm context (i.e., true-true PID 1 for lack of a better identifier)?
Maybe the try and continue approach is right?
There was a problem hiding this comment.
Looking at cloud-hypervisor's config that you linked to in #439 I see the following in the file:
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
Would this config be causing the mount to already be mounted?
There was a problem hiding this comment.
Probably so. "Resource busy" usually means that the device is already mounted afaik
There was a problem hiding this comment.
sounds like we should try and mount just in case the config doesn't exist to automatically mount it (but allow the error if it fails... maybe log a warning)
There was a problem hiding this comment.
We should probably do that for all mounts we deem essential. I'm wondering though if we should do this now or if we can postpone this to later when we allow for kernels other than the ones we control - if we ever are planning to let users provide their own kernel this at all, as this introduces a whole set of other challenges. Until that point we know with 100% certainty what is mounted and what is not.
There was a problem hiding this comment.
Lets postpone until later once we have better control of the kernels we are running.
JeroenSoeters
force-pushed
the
true-pid-1
branch
2 times, most recently
from
8f1a555 to
df5270d
Compare
JeroenSoeters
force-pushed
the
true-pid-1
branch
from
af24aa9 to
edcf3b2
Compare
JeroenSoeters
force-pushed
the
true-pid-1
branch
from
edcf3b2 to
f148666
Compare
This PR fixes a few things that were preventing
auraedto run as true PID 1. This is required for the upcoming VM work.