Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add pedalboard to benchmark page #85

Merged
merged 4 commits into from
Nov 28, 2023
Merged

DOC: add pedalboard to benchmark page #85

merged 4 commits into from
Nov 28, 2023

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Apr 20, 2022

As suggested in faroit/python_audio_loading_benchmark#21 this adds pedalboard to the benchmarks as it provides the possibility to read and access WAV, FLAC, OGG, and MP3 files since version 0.5.0. It comes bundled with JUCE and does need external libraries.

For WAV, FLAC, OGG performance is very similar to what the libsndfile based solutions achieve:

image

For MP3 it is one of the fastest libraries for reading:

image

But where it really shines is accessing metadata (as this is not part of the benchmarking I have not tested if they are also correct):

image

image

/cc @psobot

@hagenw hagenw changed the title WIP: DOC: add pedalboard to benchmark page DOC: add pedalboard to benchmark page Apr 21, 2022
@hagenw hagenw requested a review from frankenjoe April 21, 2022 07:37
@frankenjoe
Copy link
Collaborator

Wow, guess we have to take a look at pedalboard why they are that fast. At least for meta data, maybe also for reading mp3, and see if it is possible to adopt parts of it. I guess we want to avoid a direct dependency on pedalboard.

@psobot
Copy link

psobot commented Apr 23, 2022

Hi! Great to see Pedalboard included here - thanks!

One question though, you mention:

It comes bundled with JUCE and does need external libraries.

Not sure about this part; JUCE is statically linked into Pedalboard as a native library, and Pedalboard shouldn't require any external Python or native dependencies at runtime except for numpy.

I also notice that Pedalboard's mp4 speed is not listed on the graphs above; it does have MP4 support, but only when running on macOS (via OS-level bundled libraries).

@hagenw hagenw merged commit 3d231b7 into main Nov 28, 2023
28 checks passed
@hagenw hagenw deleted the pedalboard branch November 28, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants