Add support for writing to MP3 files #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, It looks good to me. P.S. I had to update my audmath version for the tests to pass, I don't know if I just used an old venv or if we should specify a minimum audmath version. |
schruefer
approved these changes
Jan 29, 2024
Very good catch, I created #148 to tackle this in a different pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing read support for MP3 file with
libsndfilein #145, this pull requests useslibsndfileto write MP3 files.The most important part is that we add
'mp3'as supported part toMAX_CHANNELSto not get an error when trying to write it. Otherwise, we just need to pass it on tosoundfileas with reading.So the main part of this pull request is updating the documentation and simplifying the tests as we no longer need ffmpeg` to create MP3 files in the tests.