Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libsndfile for reading MP3 files #139

Closed
wants to merge 2 commits into from
Closed

Use libsndfile for reading MP3 files #139

wants to merge 2 commits into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 5, 2023

Closes #119

This uses libsndfile to read MP3 files. It requires libsndfile >=1.1.0, which is also a limitation as we still have PCs around with lower versions. I would try to avoid handling MP3 differently depending on the installed libsndfile version, and maybe just wait a few more month until the old versions have finally disappeared.

NOTE: we should also update the benchmarks to see if it is faster.

@hagenw hagenw marked this pull request as draft December 5, 2023 08:46
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #139 (75eb7d3) into main (fb641f3) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
Files Coverage Δ
audiofile/core/utils.py 100.0% <100.0%> (ø)

@hagenw
Copy link
Member Author

hagenw commented Jan 19, 2024

It's part of Ubuntu >=23.04, and should be part of Debian >=12.

@hagenw
Copy link
Member Author

hagenw commented Jan 19, 2024

But maybe, soundfile is not using the system wide libsndfile installation, as I get even on Ubuntu 18.04:

>>> import soundfile
>>> soundfile.__libsndfile_version__
'1.2.0'

@hagenw
Copy link
Member Author

hagenw commented Jan 19, 2024

Closing in favor of #145

@hagenw hagenw closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use libsndfile for reading/writing MP3
1 participant