Use libsndfile for reading MP3 files #139
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119
This uses
libsndfile
to read MP3 files. It requireslibsndfile >=1.1.0
, which is also a limitation as we still have PCs around with lower versions. I would try to avoid handling MP3 differently depending on the installedlibsndfile
version, and maybe just wait a few more month until the old versions have finally disappeared.NOTE: we should also update the benchmarks to see if it is faster.