Libmicrokitco update #136
Merged
Libmicrokitco update #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops |
JE-Archer
force-pushed
the
libmicrokitco_update
branch
from
9d526dc to
7ac1fc3
Compare
Signed-off-by: James Archer <[email protected]> Co-authored-by: Bill Nguyen <[email protected]>
JE-Archer
force-pushed
the
libmicrokitco_update
branch
from
7ac1fc3 to
cf625b9
Compare
JE-Archer
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how coroutine stack pointers are passed into libmicrokitco's init function.
Previously it is a variadic function, this is susceptible to programmer error as it is easy to pass in less or more pointers than required and it is not trivial to check how many arguments a variadic function received.
Now it leverages the type system so that the compiler can caught issues statically.