Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colformat_md): respect md_extensions when part = "all" #110

Merged

Conversation

astrochemx
Copy link
Contributor

@astrochemx astrochemx commented Dec 31, 2024

Hi @atusy !
Thank you for a very helpful package!

This PR fixes an issue in the colformat_md function where the md_extensions argument was ignored when the function was called with part = "all".

Looking forward to your review and feedback. Thanks!

@atusy
Copy link
Owner

atusy commented Jan 29, 2025

@astrochemx
Oh man! Thanks a lot!!
Would you add a NEWS topic?

@astrochemx
Copy link
Contributor Author

Happy to help, @atusy !
I've updated NEWS.md and bumped the version, as seen in other PRs.

@atusy
Copy link
Owner

atusy commented Feb 3, 2025

Thanks a lot!

@atusy atusy merged commit afcb4f6 into atusy:master Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants