fix: reenable enter_accept for bash #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
ohhh fantastic! I agree, let's get it tested and then see 🤞 |
|
Did you get much of a chance to test this? I'd like to release again fairly soon with all the fixes that have landed lately. No worries if not, I can dig in soon! |
|
I've used this a bit over the past couple weeks and haven't run into any issues. I wasn't able to reproduce any of the issues people were running into and I didn't have any other problems that I could find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through old issues, and found this: #78 (comment). It appears that @yannickulrich may have already implemented a fix for our bash
enter_acceptinput issue back in their initial suggestion.It does work for me for some of the previously broken commands.
sshworks fine, as doesread -p "Say something?" tosay; echo "Say: $tosay". I do not know if there are limitations.I have intentionally made this a draft PR because I think it should be tested a bit more first (and there's probably some doc updates that need to happen). I don't know what issues there might be and we should probably test this out a bit before we re-enable it for everyone. We don't want to be causing further confusion if we can help it.
List of the issues I could find, might be a good idea to ping some threads if this turns out to be a real fix: #1372, #1390, #1379