Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ADC V2 with Async support #814

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

New ADC V2 with Async support #814

wants to merge 38 commits into from

Conversation

rnd-ash
Copy link
Contributor

@rnd-ash rnd-ash commented Jan 23, 2025 •
edited
Loading

Summary

This PR adds a new ADC API, based around a similar system to channels used by EIC and DMA peripherals.

At the moment I'll keep this as a draft PR for feedback whilst I am still finalizing bits and also adding SAMD11/21 support

Features

  • A new settings builder system for configuring the ADC
  • Channels system (Each Analog capable pin has its own channel)
  • Both blocking and Async read support
  • Buffer filling support (Free running continuous mode)
  • CPU temperature reading
  • Internal voltages reading

Progress checklist

  • SAMx51 support
  • SAMx11/21 support
  • Channels API
  • Settings builder (Mostly completed, need to add settings for Vref calibration)
  • Async/Blocking single reads
  • Async/Blocking buffer reads
  • CPU temperature reading (Restricted to primary ADC if applicable to chip)
  • CPU internal voltages reading (Restricted to primary ADC if applicable to chip)

rnd-ash and others added 30 commits January 5, 2025 11:14
@rnd-ash @jbeaurivage
Allow delay to be constructed with source (Clock V2)
e0db457
@rnd-ash @jbeaurivage
Fix compile tests and restrict source to Gclk0
29168c7
@rnd-ash
Fix compile for sam51
d8056c1
@rnd-ash
Cargo fmt
ca1e486
@rnd-ash
Merge branch 'atsamd-rs:master' into master
d7ce590
@rnd-ash
Add ADC sample settings
5dd776b
@rnd-ash
Merge branch 'atsamd-rs:master' into adc_v2
8edb4db
@rnd-ash
Begin constructing an async ADC concept for D5X
53818c7
@rnd-ash
Draft up new ADC API
7e06a82
@rnd-ash
Test implementation of async read for ADC
f2b6cc8
@rnd-ash
Resolve rest of the adc read future
98261d7
@rnd-ash
Move to type based ADC implementation
afc5430
@rnd-ash
Broken read_blocking implementation
7c76cb6
@rnd-ash
Begin implementing async reading ADC
282c02e
@jbeaurivage
Automatically convert pins to correct mode in with_pins
18cbbfe
@jbeaurivage
Remove explicit reference to a chip in favor of PAC
ba755bc
@rnd-ash
Split async and sync ADC into different implementations
9a0219d
@rnd-ash
Merge pull request #2 from jbeaurivage/adc_v2-fixes
f00feed 
Automatically convert pins to correct mode in Channel::with_pins
@rnd-ash
Clean up ADC
fa51270
@jbeaurivage
Add inlines everywhere
ebeb28a
@jbeaurivage
Add wait_flags method and do some extra cleanup
f37b36f
@jbeaurivage
Add blocking and async buffered read methods
bf25449
@rnd-ash
Merge pull request #3 from jbeaurivage/adc_v2-fixes
a9b46f0 
`wait_flags` and buffered read methods
@rnd-ash
Derive debug for Adc Error
6bbbfda
@rnd-ash
Fix ADC read_buffer not ever starting
53aafe0
@rnd-ash
Fix ADC reading blocking buffer always returning BufferOverrun
88f74f5
@rnd-ash
Implement more ADCSettings
53955a6
@rnd-ash
Add in temperature calibration parameters to calibration
9262d33
@rnd-ash
Add in CPU Temperature reading
627d9a9
@rnd-ash
Add CPU internal sensors reading, and setting VREF for adc
d0e5602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnd-ash @jbeaurivage