Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to migrate hydration based on type conditions #667

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Jan 10, 2025

Passes virtualField to the polymorphic hydration hook so we can decide which instruction to use based on the type fragments present.

Copy link

Test Results

  558 files  +2    558 suites  +2   1m 0s ⏱️ -3s
1 867 tests +4  1 382 ✅ +2  485 💤 +2  0 ❌ ±0 
1 875 runs  +4  1 390 ✅ +2  485 💤 +2  0 ❌ ±0 

Results for commit db3b912. ± Comparison against base commit a215479.

}
}
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response is

{
  "data": {
    "nothing": {
      "object": {
        "__typename": "NewObject"
      }
    },
    "old_query": {
      "object": {
        "__typename": "OldObject",
        "id": "ari:cloud:owner::type/1"
      }
    },
    "new_query": {
      "object": {
        "__typename": "NewObject",
        "id": "ari:cloud:owner::type/1"
      }
    },
    "both_query": {
      "object": {
        "__typename": "NewObject",
        "id": "ari:cloud:owner::type/1"
      }
    },
    "migrate_off": {
      "object": {
        "__typename": "OldObject",
        "id": "ari:cloud:owner::type/1"
      }
    },
    "migrate_on": {
      "object": {
        "__typename": "NewObject",
        "id": "ari:cloud:owner::type/1"
      }
    }
  }
}

@gnawf gnawf merged commit 8d486fb into master Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants