Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make union validation a soft error i.e. can still create instruction #666

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Jan 8, 2025

This means if validateUnionMembersBacked fails then we can still validate & create hydration instructions.

We still return an error, but we still create instructions for whatever is valid there.

Copy link

github-actions bot commented Jan 8, 2025

Test Results

  555 files  ±0    555 suites  ±0   59s ⏱️ -1s
1 861 tests ±0  1 378 ✅ ±0  483 💤 ±0  0 ❌ ±0 
1 869 runs  ±0  1 386 ✅ ±0  483 💤 ±0  0 ❌ ±0 

Results for commit d1e423d. ± Comparison against base commit 4a63d8f.

@gnawf gnawf merged commit 9a39029 into master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants