Union hydration validation #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 138 files ±0 138 suites ±0 58s ⏱️ +2s Results for commit 7d91dd7. ± Comparison against base commit 38ac346. This pull request removes 6 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
gnawf
commented
Jan 6, 2025
| @@ -56,13 +52,6 @@ class NadelDefaultHydrationDefinition( | |||
| val batchSize: Int | |||
| get() = appliedDirective.getArgument(Keyword.batchSize).getValue() | |||
|
|
|||
| val arguments: List<NadelHydrationArgumentDefinition> | |||
| @@ -34,11 +32,9 @@ class NadelDefaultHydrationDefinition( | |||
| "How to identify matching results" | |||
| identifiedBy: String! = "id" | |||
| "The batch size" | |||
| batchSize: Int | |||
| batchSize: Int! = 200 | |||
There was a problem hiding this comment.
Updated to match normal @hydrated definition.
Not sure why it was different to begin with.
| unionMemberType as GraphQLObjectType, | ||
| ).onErrorCast { return it } | ||
| .mapNotNull { unionMemberType -> | ||
| if ((unionMemberType as? GraphQLNamedType)?.getDefaultHydrationOrNull() == null) { |
There was a problem hiding this comment.
Only resolve hydration for those types wiith default hydration defined.
| @@ -79,36 +84,44 @@ internal class NadelIdHydrationDefinitionParser { | |||
| val defaultHydration = (type as? GraphQLNamedType)?.getDefaultHydrationOrNull() | |||
| ?: return NadelValidationInterimResult.Error.of(NadelMissingDefaultHydrationError(parent, virtualField)) | |||
|
|
|||
| val hydration = object : NadelHydrationDefinition { | |||
There was a problem hiding this comment.
Made this a named class
temaEmelyan
approved these changes
Jan 7, 2025
bbakerman
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to
@hydratedthat returns the union member type.