Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type duplication to build command #144

Merged
merged 2 commits into from
Dec 20, 2024
Merged

add type duplication to build command #144

merged 2 commits into from
Dec 20, 2024

Conversation

PatrickAtlassian
Copy link
Contributor

Description

Making local dev loop smoother for Gitlab app with generating the types file on build, and clarifying to contributors which file to edit.

Checklist

Please ensure that each of these items has been addressed:

  • I have tested these changes in my local environment
  • I have added/modified tests as applicable to cover these changes
  • (Atlassian contributors only) I have removed any Atlassian-internal changes including internal modules, references to internal tickets, and internal wiki links

@PatrickAtlassian PatrickAtlassian requested a review from a team as a code owner December 20, 2024 23:13
@PatrickAtlassian PatrickAtlassian merged commit 2625011 into main Dec 20, 2024
5 checks passed
@PatrickAtlassian PatrickAtlassian deleted the COMPASS-23586-clarify-type-duplication branch December 20, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbuvenk-atlas subbuvenk-atlas subbuvenk-atlas approved these changes

@eserranovalle eserranovalle eserranovalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickAtlassian @eserranovalle @subbuvenk-atlas