Light Pending phase refactor help with future work to deal with problem nodes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. The one thing I'd consider is can you think of a test to add that would capture the new behaviour, so we can verify it stays that way over time? |
|
@mwhittington21 I've added a new test. It succeeds when run with the changes of this PR and I've confirmed that on master the test fails as expected. |
mwhittington21
approved these changes
Aug 19, 2024
awprice
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to refactor the Pending phase to set the stage for dealing with the different kinds of problem nodes that can occur when collecting the nodes in the Pending phase. This PR does makes minimal changes to the behavior or cyclops. All tests pass as before.
Moving the check for the equilibrium timeout to the start of the Pending phase. This feels like more appropriate placement as it should run before any attempts that are made to fix the state of the nodes in kube and the cloud provider. If it reaches the time to time out then it should fail, not have another attempt at fixing things since the timeout period is long enough at 5 minutes.