Fix broken css prop ternaries when referencing cssMap objects.
#1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional expressions. Fixes #1750 We simply copy the direct `buildCss > MemberExpression > …` extraction into a new path through `buildCss > ConditionalExpression > extractConditionalExpression(…) > MemberExpression > …`.
kylorhall-atlassian
requested review from
JakeLane,
pancaspe87,
liamqma,
dddlr and
zesmith2
as code owners
🦋 Changeset detectedLatest commit: 5bcb62a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
| }; | ||
| } | ||
|
|
||
| if (fallbackToEvaluate) { |
There was a problem hiding this comment.
I feel a bit annoyed by adding this false here, but I get into this endless loop with non-cssMap objects, eg. loading ? colors.N20 : colors.N40 where it blew up in a test.
This keeps it 1:1 with the current state by default and lets this if (bindingIdentifier && meta.state.cssMap[bindingIdentifier.name]) { flow be reused in extractConditionalExpression, so it feels sane to me.
dddlr
reviewed
Dec 18, 2024
packages/babel-plugin/src/styled/__tests__/tagged-template-expression.test.ts
Outdated
Show resolved
Hide resolved
dddlr
previously approved these changes
Dec 18, 2024
dddlr
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
We extract nested member expressions inside of conditional expressions.
Why are we making this change?
Fixes #1750
How are we making this change?
We simply copy the direct
buildCss > MemberExpression > …extraction into a new path throughbuildCss > ConditionalExpression > extractConditionalExpression(…) > MemberExpression > ….…I believe this is safe and well protected, given the underlying
extractMemberExpressioncode already existed!PR checklist
I have...
Updated the documentation inn/awebsite/