Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken releases following bringing the Compiled website in. #1699

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

kylorhall-atlassian
Copy link
Collaborator

I believe following #1677 our releases have started to fail.

Example error: https://github.com/atlassian-labs/compiled/actions/runs/10032812760/job/27725059509#step:6:26

This is because yarn release runs yarn build at the root which runs the website which has a dependency not installed via the root yarn install command, so this adds workspaces-run to the root yarn.lock.

Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: 4cfc358

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for compiled-css-in-js canceled.

Name Link
🔨 Latest commit 4cfc358
🔍 Latest deploy log https://app.netlify.com/sites/compiled-css-in-js/deploys/669db47f3d155e0008852e08

I believe following #1677 our releases have started to fail.

Example error: https://github.com/atlassian-labs/compiled/actions/runs/10032812760/job/27725059509#step:6:26

This is because `yarn release` runs `yarn build` at the root which runs the website which has a dependency not installed via the root `yarn install` command, so this adds `workspaces-run` to the root `yarn.lock`.
@kylorhall-atlassian kylorhall-atlassian merged commit 6ddeee2 into master Jul 22, 2024
13 checks passed
@kylorhall-atlassian kylorhall-atlassian deleted the fix-broken-releases branch July 22, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants