Skip to content

Commit

Permalink
Fix border-inline-start and border-inline-end not having any valid or…
Browse files Browse the repository at this point in the history
…dering (#1756)

* Fix border-inline-start and border-inline-end not having any valid ordering

* Undo addition of packageManager
  • Loading branch information
dddlr authored Dec 11, 2024
1 parent 3c5618b commit 6fb2894
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/unlucky-boxes-brake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@compiled/eslint-plugin': patch
'@compiled/utils': patch
---

Fix border-inline-start and border-inline-end not having any valid ordering in the shorthand-property-sorting ESLint rule
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,23 @@ tester.run('shorthand-property-sorting', shorthandFirst, {
export const EmphasisText = ({ children, status }) => <span css={containerAppearance[status]}>{children}</span>;
`,
},

//
// has a valid sorting for borderInlineStart and borderInlineEnd
//

{
name: 'has a valid sorting for borderInlineStart and borderInlineEnd',
code: `
import { styled } from '@compiled/react';
const Bap = styled.div({
borderTop: 'none',
borderInlineStart: 'none',
borderInlineEnd: 'none',
});
`,
},
]),

invalid: includedImports.flatMap((imp) => [
Expand Down
6 changes: 0 additions & 6 deletions packages/utils/src/shorthand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,6 @@ export const shorthandFor: Record<ShorthandProperties, true | readonly string[]>
'border-inline-end-color',
'border-inline-end-style',
'border-inline-end-width',
'border-left-color',
'border-left-style',
'border-left-width',
'border-right-color',
'border-right-style',
'border-right-width',
Expand All @@ -246,9 +243,6 @@ export const shorthandFor: Record<ShorthandProperties, true | readonly string[]>
'border-left-color',
'border-left-style',
'border-left-width',
'border-right-color',
'border-right-style',
'border-right-width',
],
'border-left': [
'border-inline-start-color',
Expand Down

0 comments on commit 6fb2894

Please sign in to comment.