Resolve Jira API requests between JSM/JS/Jira to correct permission map/resolver #62
+87
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxu2atlassian
force-pushed
the
feat/EAS-2549
branch
6 times, most recently
from
fecbc4d to
7de9e27
Compare
jwong101
reviewed
Jan 3, 2025
| } | ||
| _ => { | ||
| warn!("First parameter to requestJira() is invalid"); | ||
| IntrinsicName::RequestJira // TODO: how should we handle this edge case? |
There was a problem hiding this comment.
If we want to produce the least amount of false positives, then we should conservatively assume it can use any of Jira APIs if we can't statically determine which one.
There was a problem hiding this comment.
Just to clarify, do you mean create another IntrinsicName enum like IntrinsicName::RequestJiraAny and then have that correspond to a combined resolver/regex map of JS + Jira + JSM here?
dxu2atlassian
force-pushed
the
feat/EAS-2549
branch
from
7de9e27 to
8becec8
Compare
dxu2atlassian
force-pushed
the
feat/EAS-2549
branch
from
7e81927 to
32f1b4f
Compare
jwong101
reviewed
Jan 11, 2025
| url if url.starts_with("/rest/servicedeskapi/") => { | ||
| Some(IntrinsicName::RequestJiraServiceManagement) | ||
| } | ||
| url if url.starts_with("/rest/agile/") => Some(IntrinsicName::RequestJiraSoftware), |
There was a problem hiding this comment.
There are other Jira Software URL patterns like /rest/devinfo and /rest/builds. See the API docs for others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSM/JS/Jira all seem to be bundled within requestJira inside Forge, this will separate those requests and route them to the proper permission map/resolver for classification.