Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EAS-2088 : Create a Simple Test Framework #41

Merged
merged 19 commits into from
May 20, 2024
Merged

EAS-2088 : Create a Simple Test Framework #41

merged 19 commits into from
May 20, 2024

Conversation

gersbach
Copy link
Contributor

@gersbach gersbach commented Apr 2, 2024

No description provided.

@gersbach
Copy link
Contributor Author

gersbach commented Apr 2, 2024

wait, i see it is failing the clippy check. let me fix that 🙂

@jwong101
Copy link
Contributor

jwong101 commented Apr 2, 2024

It's only the formatter that's failing at the moment. Make sure you run cargo fmt --all, which should resolve it.

@jwong101 jwong101 self-assigned this Apr 2, 2024
@gersbach
Copy link
Contributor Author

gersbach commented Apr 2, 2024

It's only the formatter that's failing at the moment. Make sure you run cargo fmt --all, which should resolve it.

nice! it worked. thank you

jwong101
jwong101 reviewed Apr 2, 2024
View reviewed changes
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
@gersbach
Copy link
Contributor Author

gersbach commented Apr 5, 2024

I'll rebase once it's approved :)

jwong101
jwong101 requested changes May 6, 2024
View reviewed changes
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/test.rs Show resolved Hide resolved
@gersbach gersbach force-pushed the feature/EAS-2088 branch 3 times, most recently from 2e06862 to 1800a8e Compare May 7, 2024 20:35
@gersbach gersbach force-pushed the feature/EAS-2088 branch from 1800a8e to d36a16d Compare May 7, 2024 20:43
jwong101
jwong101 requested changes May 13, 2024
View reviewed changes
crates/fsrt/src/test.rs Outdated Show resolved Hide resolved
jwong101
jwong101 requested changes May 13, 2024
View reviewed changes
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/forge_project.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/test.rs Outdated Show resolved Hide resolved
jwong101
jwong101 requested changes May 16, 2024
View reviewed changes
crates/forge_analyzer/src/reporter.rs Outdated Show resolved Hide resolved
crates/forge_loader/src/manifest.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Outdated Show resolved Hide resolved
crates/fsrt/src/main.rs Show resolved Hide resolved
crates/fsrt/src/test.rs Outdated Show resolved Hide resolved
crates/fsrt/src/test.rs Outdated Show resolved Hide resolved
crates/fsrt/src/test.rs Outdated Show resolved Hide resolved
crates/fsrt/src/test.rs Outdated Show resolved Hide resolved
@jwong101 jwong101 merged commit 326b371 into atlassian-labs:main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwong101 jwong101 jwong101 requested changes

Assignees

@jwong101 jwong101

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gersbach @jwong101