replace sporadic use of private attributes with public properties #20
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italovalcy
requested changes
Jan 23, 2025
There was a problem hiding this comment.
@SColson82 for the SDXClient class, the usage of the private attributes seems right instead of using properties. Indeed, the class does not define the properties actually, so probably the code will break with the proposed changes.
In summary, of the SDXClient you can keep using the _xyz attribute names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adding the http_username and http_password I realized that I had a few occasions where I was using the private attributes rather than the public properties. I believe I have corrected all of the instances of this and would like to merge the change into the main branch.