Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datamodel new tag #247

Merged
merged 7 commits into from
Jan 14, 2025
Merged

datamodel new tag #247

merged 7 commits into from
Jan 14, 2025

Conversation

YufengXin
Copy link
Collaborator

Enforce validation checks on connection requests.

@YufengXin YufengXin self-assigned this Jan 13, 2025
@YufengXin YufengXin linked an issue Jan 13, 2025 that may be closed by this pull request
Validating against time and qos_metrics values #246
Closed
@YufengXin YufengXin marked this pull request as draft January 13, 2025 20:10
@coveralls
Copy link

coveralls commented Jan 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12770405058

Details

  • 8 of 15 (53.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 90.95%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sdx_pce/utils/exceptions.py 3 5 60.0%
src/sdx_pce/topology/temanager.py 5 10 50.0%
Totals Coverage Status
Change from base Build 12205375372: -0.3%
Covered Lines: 1192
Relevant Lines: 1304
💛 - Coveralls

@YufengXin YufengXin marked this pull request as ready for review January 14, 2025 14:47
@YufengXin YufengXin requested review from sajith and congwang09 and removed request for sajith January 14, 2025 15:08
@YufengXin YufengXin merged commit 95db29a into main Jan 14, 2025
11 checks passed
@YufengXin YufengXin deleted the 246-validating-against-time-and-qos_metrics-values branch January 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congwang09 congwang09 congwang09 approved these changes

Assignees

@YufengXin YufengXin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validating against time and qos_metrics values
3 participants
@YufengXin @coveralls @congwang09