Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging #152

Merged
merged 27 commits into from
Jan 9, 2024
Merged

Add logging #152

merged 27 commits into from
Jan 9, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 9, 2023

Fixes #59.

@sajith sajith added the enhancement New feature or request label Aug 9, 2023
@sajith sajith self-assigned this Aug 9, 2023
@coveralls
Copy link

coveralls commented Aug 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7465848622

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 79.947%
Totals Coverage Status
Change from base Build 6318436655: -0.6%
Covered Lines: 892
Relevant Lines: 1096
💛 - Coveralls

sajith added 11 commits August 9, 2023 06:44
@sajith
Merge remote-tracking branch 'origin/main' into 59.logging
73b401e
@sajith
Remove old comment
9bbc438
@sajith
Link to pytest
ea16885
@sajith
Update tox example
a3f7a35
@sajith
Update notes about testing
8c5e045
@sajith
These are not real console sessions
9bd5f5b
@sajith
Reword tox usage
3ca158d
@sajith
Correct log message
26c3a29
@sajith
Set up logging
5569502
@sajith
Use logger instead of direct logging call
b342680 
This is better:

> WARNING sdx_pce.topology.manager:manager.py:225 This port (id:
> urn:ogf:network:sdx:port:sax:B1:1) does not belong to any node in
> the topology, likely a Non-SDX port!

... compared to:

> WARNING root:manager.py:223 This port (id:
> urn:ogf:network:sdx:port:sax:B1:1) does not belong to any node in
> the topology, likely a Non-SDX port!
@sajith
Remove do-nothing logging handler
d9bd9c7 
We _do_ want errors and warnings to be printed when they happen.

https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library
@sajith sajith marked this pull request as draft August 16, 2023 19:35
@sajith sajith marked this pull request as ready for review January 5, 2024 22:08
@sajith sajith requested review from YufengXin and congwang09 January 5, 2024 22:08
@sajith sajith merged commit 9e67d4d into main Jan 9, 2024
11 checks passed
@sajith sajith deleted the 59.logging branch January 9, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congwang09 congwang09 congwang09 approved these changes

@YufengXin YufengXin Awaiting requested review from YufengXin

Assignees

@sajith sajith

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer logging to print statements
3 participants
@sajith @coveralls @congwang09