Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-5019: Add CrendentialClient.creator() (with the optional "host" and "port" params) #491

Merged
merged 15 commits into from
Feb 4, 2025

Conversation

vaibhavatlan
Copy link
Collaborator

@vaibhavatlan vaibhavatlan commented Jan 28, 2025

  • Add CredentialClient.creator() (ensure optional parameters are supported).

  • Refactor existing SDK code that creates credential objects to use the new CredentialClient.creator() method.

  • Add two new optional parameters, host and port, to Connection.creator() to allow users to populate these fields for the UI if needed.

  • Added CredentialClient.purge_by_guid() for Hard delete of Credential

  • Added code

  • Added unit test

  • Added Integration test

  • Updated docs

@vaibhavatlan vaibhavatlan self-assigned this Jan 28, 2025
@vaibhavatlan vaibhavatlan added the feature New feature or request label Jan 28, 2025
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Aryamanz29 Aryamanz29 merged commit 58ff4cd into main Feb 4, 2025
49 of 51 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-5019 branch February 4, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants