feat: don't reload your app and auth in a popup #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atinux
reviewed
Feb 4, 2025
Comment on lines
+5
to
+15
| const PROVIDERS = { | ||
| github: { | ||
| width: 960, | ||
| height: 600, | ||
| }, | ||
| gitlab: { | ||
| width: 1100, | ||
| height: 650, | ||
| }, | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think we should have the providers with fixed width/height
atinux
reviewed
Feb 4, 2025
| @@ -38,12 +49,48 @@ export function useUserSession(): UserSessionComposable { | |||
| } | |||
| } | |||
|
|
|||
| const isInPopup = useCookie('temp-nuxt-auth-utils-popup') | |||
|
|
|||
| const openInPopup = (provider, route) => { | |||
There was a problem hiding this comment.
I would rather have onpenInPopup('/auth/github', { width: 690, height: 600 }) with default values for both width & height so we could have openInPopup('/auth/github')
There was a problem hiding this comment.
With and Height are here to match the minimal size of the website provider and prevent scrollbars. The goal is to display the popup at the minimal size.
Are you sure to force developers to remember which is the perfect size for each providers, and set it for each providers ?
atinux
reviewed
Feb 4, 2025
Comment on lines
74
to
76
| watch(isInPopup, () => { | ||
| fetch() | ||
| }) |
There was a problem hiding this comment.
Suggested change
| watch(isInPopup, () => { | |
| fetch() | |
| }) | |
| watch(isInPopup, fetch) |
|
Thank you for the ideas, I added somes notes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kooha-2025-02-04-03-38-18.webm