#848 Upgrade Selenium.WebDriver package reference to v4.28.0

atata-framework · Jan 25, 2025 · eb903c2 · eb903c2
1 parent b95a69a
commit eb903c2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/Atata/Atata.csproj b/src/Atata/Atata.csproj
@@ -38,9 +38,7 @@ Features:
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Selenium.WebDriver" Version="4.26.1" />
-    <!-- Temporarily referencing System.Text.Json v8.0.5, because Selenium.WebDriver referencing vulnerable v8.0.4. -->
-    <PackageReference Include="System.Text.Json" Version="8.0.5" />
+    <PackageReference Include="Selenium.WebDriver" Version="4.28.0" />
     <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.6.0" />
   </ItemGroup>
 

diff --git a/src/Atata/Logging/Screenshots/CdpFullPageScreenshotStrategy.cs b/src/Atata/Logging/Screenshots/CdpFullPageScreenshotStrategy.cs
@@ -34,7 +34,7 @@ public FileContentWithExtension TakeScreenshot(WebDriverSession session)
             .GetAwaiter()
             .GetResult();
 
-        var data = commandResult["data"].ToString();
+        string data = commandResult.Value.GetProperty("data").GetString();
         return FileContentWithExtension.CreateFromBase64String(data, ".png");
     }
 }
diff --git a/src/Atata/Logging/Snapshots/CdpPageSnapshotStrategy.cs b/src/Atata/Logging/Snapshots/CdpPageSnapshotStrategy.cs
@@ -26,7 +26,7 @@ public FileContentWithExtension TakeSnapshot(WebDriverSession session)
             .GetAwaiter()
             .GetResult();
 
-        var data = commandResult["data"].ToString();
+        string data = commandResult.Value.GetProperty("data").GetString();
         return FileContentWithExtension.CreateFromText(data, ".mhtml");
     }
 }