Skip to content

Commit

Permalink
Fix lint on CI (#154)
Browse files Browse the repository at this point in the history
  • Loading branch information
at-wat authored Apr 21, 2021
1 parent 846a52f commit 47d783c
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,6 @@ jobs:
uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go }}
- name: Install golint
if: env.REVIEWDOG_ON == matrix.go
run: |
go get golang.org/x/lint/golint
go install golang.org/x/lint/golint
git reset --hard HEAD
golint ./...
- name: Run go test
run: |
go vet ./...
Expand Down
25 changes: 25 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: lint
on:
pull_request:
branches:
- master
push:
branches:
- master

jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Go
uses: actions/setup-go@v2
- name: Install golint
run: |
go get golang.org/x/lint/golint
go install golang.org/x/lint/golint
echo $(go env GOPATH)/bin >> ${GITHUB_PATH}
- name: Lint
run: |
golint ./... | sed 's/^\([^:]\+\):\([0-9]\+\):\([0-9]\+\): \(.*\)$/::warning file=\1,line=\2,col=\3::\4/'
1 change: 1 addition & 0 deletions mkvcore/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ func WithMaxKeyframeInterval(mainTrackNumber uint64, interval int64) BlockWriter
// BlockReaderOptionFn configures a BlockReaderOptions.
type BlockReaderOptionFn func(*BlockReaderOptions) error

// ApplyToBlockReaderOptions implements BlockReaderOption.
func (o BlockReaderOptionFn) ApplyToBlockReaderOptions(opts *BlockReaderOptions) error {
return o(opts)
}
Expand Down

0 comments on commit 47d783c

Please sign in to comment.