Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the swags and goodies card #3599

Merged
merged 5 commits into from
Jan 25, 2025

Conversation

Aryan4884
Copy link
Contributor

@Aryan4884 Aryan4884 commented Jan 22, 2025

[Issue] #3597
Screenshot 2025-01-22 214543

Summary by CodeRabbit

Summary by CodeRabbit

  • Style
    • Enhanced the layout of the "Finance" card with improved padding, background color, rounded corners, and shadow effects.
    • Removed the "Store" card from the rendered output while preserving the overall structure of the page.

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

Walkthrough

The pull request introduces layout and styling modifications to the CommunityIndexPage component in the pages/community/index.tsx file. The previous structure for the "Finance" card has been updated to a new centered layout within a styled container, featuring enhanced padding, background color, rounded corners, and shadow effects. The "Store" card has been commented out, removing it from the rendered output, while the "Finance" card remains unchanged in its properties. The overall functionality of the component is preserved.

Changes

File Change Summary
pages/community/index.tsx Updated layout for "Finance" card with new styling; commented out "Store" card.

Possibly related PRs

Suggested Labels

ready-to-merge

Suggested Reviewers

  • derberg
  • akshatnema
  • magicmatatjahu
  • Mayaleeeee
  • asyncapi-bot-eve
  • devilkiller-ag
  • sambhavgupta0705
  • anshgoyalevil

Poem

🐰 In the community, a card takes its place,
Styled with care, it’s a beautiful space.
The "Store" card has waved its goodbye,
While the "Finance" card shines, oh my!
With rounded corners and shadows that play,
Our layout’s transformed, hip-hip-hooray! ✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72a3dbe and ed60677.

📒 Files selected for processing (1)
  • pages/community/index.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pages/community/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5357460
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/679111e9d9db5e000920d5cd
😎 Deploy Preview https://deploy-preview-3599--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aryan4884 Aryan4884 changed the title fix: Removed the swags and goodies card fix: removed the swags and goodies card Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ed60677
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6793ec2e5e54170008ac1fa6
😎 Deploy Preview https://deploy-preview-3599--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jan 22, 2025

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3599--asyncapi-website.netlify.app/

@Aryan4884 Aryan4884 force-pushed the bug/Swag_and_Goodies_Card branch from 72a3dbe to 1863906 Compare January 22, 2025 16:04
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (745d3f4) to head (ed60677).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          732       732           
=========================================
  Hits           732       732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iambami
Copy link
Contributor

iambami commented Jan 23, 2025

Thank you, @Aryan4884

The maintainers will review it.

cc/ @akshatnema @derberg

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and pull the latest changes from master.

Looks good to me. Thank you' @Aryan4884

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 282493d into asyncapi:master Jan 25, 2025
22 checks passed
@iambami
Copy link
Contributor

iambami commented Jan 29, 2025

Thank you @Aryan4884 for working on this issue.

You can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants