fix: add scrollable Community dropdown to display all content #3553
Conversation
rahulrana701
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
|
Warning Rate limit exceeded@rahulrana701 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 33 minutes and 56 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces minor styling modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
rahulrana701
changed the title
rahulrana701
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3553--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
components/navigation/FlyoutMenu.tsx (1)
Missing tailwind-scrollbar plugin for custom scrollbar styles
The component uses Tailwind scrollbar classes (
scrollbar-thin,scrollbar-thumb-white,scrollbar-track-transparent) but the requiredtailwind-scrollbarplugin is not configured in the project. These classes won't have any effect on the scrollbar styling.To fix this:
- Install the
tailwind-scrollbarplugin- Add it to the plugins array in
tailwind.config.js- Or replace the current classes with custom CSS scrollbar styling using the existing
.scroll-noneutility as a reference🔗 Analysis chain
Line range hint
1-27: Well-structured implementation of scrollable dropdown.The component effectively implements a scrollable dropdown with appropriate height constraints and maintains good TypeScript practices. The changes successfully address the PR objective of making the Community dropdown scrollable.
Let's verify the scrollbar plugin dependency:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if tailwind-scrollbar plugin is properly configured grep -r "tailwindcss/scrollbar\|tailwind-scrollbar" .Length of output: 55
Script:
#!/bin/bash # Check package.json for tailwind-scrollbar dependency cat package.json | grep -A 5 -B 5 "scrollbar" # Check tailwind configuration files fd -e js -e cjs -e ts "tailwind.config" --exec cat {}Length of output: 5848
🧰 Tools
🪛 eslint
[error] 17-17: Replace
"absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2"with'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace
"Flyout-main"with'Flyout-main'(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace
"rounded-lg·shadow-lg"with'rounded-lg·shadow-lg'(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace
"shadow-xs·overflow-hidden·rounded-lg"with'shadow-xs·overflow-hidden·rounded-lg'(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace
"relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent"with'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-21: Double quotes used instead of single quotes for JSX attributes
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/navigation/FlyoutMenu.tsx(1 hunks)
🧰 Additional context used
🪛 eslint
components/navigation/FlyoutMenu.tsx
[error] 17-17: Replace "absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2" with 'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'
(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace "Flyout-main" with 'Flyout-main'
(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace "rounded-lg·shadow-lg" with 'rounded-lg·shadow-lg'
(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "shadow-xs·overflow-hidden·rounded-lg" with 'shadow-xs·overflow-hidden·rounded-lg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace "relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent" with 'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
components/navigation/FlyoutMenu.tsx
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-21: Double quotes used instead of single quotes for JSX attributes
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
components/navigation/FlyoutMenu.tsx
Outdated
| className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2" | ||
| data-testid="Flyout-main" | ||
| > | ||
| <div className='rounded-lg shadow-lg'> | ||
| <div className='shadow-xs overflow-hidden rounded-lg'> | ||
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | ||
| <div className="rounded-lg shadow-lg"> | ||
| <div className="shadow-xs overflow-hidden rounded-lg"> | ||
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> |
There was a problem hiding this comment.
Fix quote style to match project conventions.
Replace double quotes with single quotes in JSX attributes to comply with project conventions and fix CI failures.
Apply this change across all JSX attributes:
- className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2"
+ className='absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2'
- data-testid="Flyout-main"
+ data-testid='Flyout-main'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2" | |
| data-testid="Flyout-main" | |
| > | |
| <div className='rounded-lg shadow-lg'> | |
| <div className='shadow-xs overflow-hidden rounded-lg'> | |
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | |
| <div className="rounded-lg shadow-lg"> | |
| <div className="shadow-xs overflow-hidden rounded-lg"> | |
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> | |
| className='absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2' | |
| data-testid='Flyout-main' | |
| > | |
| <div className='rounded-lg shadow-lg'> | |
| <div className='shadow-xs overflow-hidden rounded-lg'> | |
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent'> |
🧰 Tools
🪛 eslint
[error] 17-17: Replace "absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2" with 'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'
(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace "Flyout-main" with 'Flyout-main'
(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace "rounded-lg·shadow-lg" with 'rounded-lg·shadow-lg'
(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "shadow-xs·overflow-hidden·rounded-lg" with 'shadow-xs·overflow-hidden·rounded-lg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace "relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent" with 'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-21: Double quotes used instead of single quotes for JSX attributes
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
components/navigation/FlyoutMenu.tsx
Outdated
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | ||
| <div className="rounded-lg shadow-lg"> | ||
| <div className="shadow-xs overflow-hidden rounded-lg"> | ||
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Review scrollbar visibility and fix class ordering.
Two concerns with the scrollbar implementation:
- A white scrollbar thumb (
scrollbar-thumb-white) on a white background (bg-white) might be difficult to see. - Tailwind classes should follow the recommended ordering convention.
Consider these improvements:
- Use a different color for better contrast:
- <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent">
+ <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent">- Reorder Tailwind classes following the convention:
- <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent">
+ <div className="relative z-20 max-h-96 min-h-40 grid gap-6 bg-white px-5 py-6 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent sm:gap-8 sm:p-8 lg:grid-cols-2">📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> | |
| <div className="relative z-20 max-h-96 min-h-40 grid gap-6 bg-white px-5 py-6 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent sm:gap-8 sm:p-8 lg:grid-cols-2"> |
🧰 Tools
🪛 eslint
[error] 22-22: Replace "relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent" with 'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 668 668
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
The "Community" dropdown should display all its content, even if the content exceeds the available space. A scrollbar should appear when the dropdown content is too large, allowing users to scroll through the options.
#3549
Summary by CodeRabbit