Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add formatting.md #1359
docs: add formatting.md #1359
Changes from 7 commits
0129733
5e528a3
705b144
0d6ec42
e252a13
517dfc7
6433bfd
518a3ee
dfce213
bd03ef2
73c720d
5c4f62a
ba19e1e
4f3aeb9
95d4651
ad81a63
7401a66
f65e34a
dfa1ec7
ff80d1e
77b7e71
75d2447
91d7f5c
758580f
0b89fe4
52d6653
8151476
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the number for the page weight missing? please assign one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a paragraph or sentence introducing the topic "Documentation formatting".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire section is confusing, and I can't understand it. 😄✌🏽 What are you documenting here? It is not clear that you're explaining that we have a React component for creating a remember card.
Also, why do you have the
(remember)
in the middle of that sentence in line 20? What do you mean by "no need to add a prefix"? What prefix are you talking about? 👀Please rewrite this section and think about all the pieces you are trying to educate the reader on ✌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even after adding tags some people might think they need to write "Remember" inside of tags to make it work. That's what I wanted to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.