docs: adding optional version to the message object #558
Conversation
IsmaelMartinez
requested review from
fmvilas,
derberg,
dalelane,
smoya,
char0n,
GreenRover,
jonaslagoni,
Pakisan and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Looks good to me. I'm not approving because, although I'm a maintainer of the repo, I've been completely disconnected from the work it's happening here and I'm not sure these are the files we should be touching 😅 Therefore, leaving it to others who are more engaged.
|
@IsmaelMartinez looks good Waiting for test to test new property |
There was a problem hiding this comment.
@IsmaelMartinez make sure to change the definitions not the schemas as they are automatically generated on each release 🙂
You can find the message object here: https://github.com/asyncapi/spec-json-schemas/blob/master/definitions/3.0.0/messageObject.json
|
Thanks for the review. I will see if I can make those changes later on. 1st time in here so apologies for silly mistakes ;) |
… of the generated schema
|
|
Hi all, I just made the changes. We got an conversation open on the RFC but hopefully we can reach a consensus in the near future. |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
Add optional version to the message object
Part of the asyncapi/spec#1068 RFC 0
Related issue(s)
asyncapi/spec#1068
asyncapi/spec#1069