fix: automated updation of voteTrackingFile.json on removal of a TSC Member #1626
Conversation
kaneki003
requested review from
derberg,
asyncapi-bot-eve and
thulieblack
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
kaneki003
changed the title
kaneki003
changed the title
There was a problem hiding this comment.
@kaneki003 please run a test in your fork and provide links for review.
also problem with current implementation is that it will work only with "new" removals, so your PR also should do manual removal of emeritus from voting overview.
did you consider that maybe better would be to make a change in https://github.com/asyncapi/community/blob/master/.github/scripts/vote_tracker.js?
| @@ -21,44 +21,44 @@ jobs: | |||
| uses: actions/github-script@v6 | |||
There was a problem hiding this comment.
are changes in this fine necessary or just simple style refresh, autoformatter?
| @@ -165,6 +165,24 @@ jobs: | |||
| core.setFailed(`Failed to remove ${maintainer.githubUser} from the team: ${error.message}`); | |||
| } | |||
| } | |||
| - name: Update voteTrackingFile.json | |||
There was a problem hiding this comment.
it's good direction, but you need to put some more work in it
- you need to test it manually on a test repo, maybe on fork it will work - and proof it works
- you need to make sure the changes in the file are in the end reflected in the repo. Now, your workflow will update json file, but in the virtual machine, where this job runs - not in actual repository. Look at
update_emeritusjob for inspiration. Probably better if your step is acutally done as part ofupdate_emeritus- so just one PR is done with 2 files changed.
also you need to manually remove any emeritus from https://github.com/asyncapi/community/blob/master/TSC_VOTING_OVERVIEW.md is still there
also, voteTrackingFile.json update should also be reflected in TSC_VOTING_OVERVIEW.md. Might be that some refactor of https://github.com/asyncapi/community/blob/master/.github/scripts/vote_tracker.js is needed. We might need a separate function we can run in automation, just to refresh the file basing on curren voteTrackingFile.json with no need on voting to happen
Description
Related issue(s)
Resolves #1600