Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ui/ux improvements in config commands #1518

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Wck-iipi
Copy link

Description

Added UI/UX improvements to config commands and subcommands. The changed commands will look as follows:
Fixes: #1380
image

image

image

image

image

image

image

image

image

image

image

Related issue(s)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

@Wck-iipi
Copy link
Author

@Amzani Do above look good? I have coloured them according to description. Please tell me if something needs to be changed.

Amzani
Amzani previously approved these changes Sep 11, 2024
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Awesome work @Wck-iipi thanks!

@Wck-iipi
Copy link
Author

@Amzani Is there anything else I have to do to get this merged? Thans

@Shurtu-gal
Copy link
Collaborator

/update

Copy link

changeset-bot bot commented Dec 21, 2024

🦋 Changeset detected

Latest commit: 50e3e6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Shurtu-gal Shurtu-gal changed the title chore: added ui/ux improvements in config commands feat: add ui/ux improvements in config commands Dec 21, 2024
@Shurtu-gal
Copy link
Collaborator

@Wck-iipi you would have to update the tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Implement new UI/UX improvements in config command
4 participants