Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin fine filtering. #421

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Temporarily remove fine filtering.

See astronomy-commons/hats-import#434

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (c27133d) to head (2dca8ec).
Report is 1 commits behind head on margin.

Additional details and impacted files
@@            Coverage Diff             @@
##           margin     #421      +/-   ##
==========================================
- Coverage   93.02%   92.98%   -0.05%     
==========================================
  Files          47       46       -1     
  Lines        2123     2066      -57     
==========================================
- Hits         1975     1921      -54     
+ Misses        148      145       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

github-actions bot commented Nov 18, 2024

Before [c27133d] After [b19fee4] Ratio Benchmark (Parameter)
23.2±0.2ms 24.4±0.7ms 1.05 benchmarks.MetadataSuite.time_load_partition_info_order6
109±1ms 111±1ms 1.02 benchmarks.Suite.time_paths_creation
95.0±0.3ms 95.5±0.8ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
94.9±0.2ms 95.6±0.9ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
46.1±0.3ms 46.6±0.5ms 1.01 benchmarks.Suite.time_pixel_tree_creation
383±1ms 385±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
126±0.3ms 126±0.7ms 1 benchmarks.time_test_alignment_even_sky
1.05±0.02ms 1.03±0.03ms 0.98 benchmarks.time_test_cone_filter_multiple_order
15.2±0.8ms 14.4±0.9ms 0.94 benchmarks.Suite.time_inner_pixel_alignment

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu changed the base branch from main to margin November 18, 2024 17:18
@delucchi-cmu delucchi-cmu merged commit f732d78 into margin Nov 18, 2024
10 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/margin/remove_fine branch November 18, 2024 17:25
delucchi-cmu added a commit that referenced this pull request Nov 26, 2024
* Remove margin fine filtering.

* Remove unused unseen.

* Remove margin fine filtering. (#421)

* Remove margin fine filtering.

* Remove unused unseen.

* Use cdshealpix for margin pixel finding.

* Unused import.

* add color_by_order option and plot on existing axes

* reset matplotlib after tests

* pylint

* Migrate ang2vec (#426)

* Use astropy for ang2vec conversion

* Allow for kwargs in ang2vec

* use mindist instead of resol for margin filter

* Replace healpy in healpix_shim pixel math operations

* isort

* support np arrays

* use order instead of nside

* remove unused variable

* Return int64 from radec2pix (#432)

* Migrate box filtering to use MOCpy (#428)

* Use mocpy in box filtering

* Update tests

* Ensure moc is correct in box filter test

* Remove unused healpy methods

* Pin mocpy

* Remove healpy references. (#433)

* Address merge conflicts

---------

Co-authored-by: Sean McGuire <[email protected]>
Co-authored-by: Sean McGuire <[email protected]>
Co-authored-by: Sandro Campos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants