Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_pandas_storage_options #296

Merged
merged 5 commits into from
Jul 12, 2024
Merged

handle_pandas_storage_options #296

merged 5 commits into from
Jul 12, 2024

Conversation

Schwarzam
Copy link
Contributor

This PR closes #295.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

New Feature Checklist

Copy link

github-actions bot commented Jun 18, 2024

Before [97643b6] After [2f79370] Ratio Benchmark (Parameter)
40.9±1ms 41.8±0.8ms 1.02 benchmarks.Suite.time_pixel_tree_creation
78.0±0.8ms 78.7±1ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
77.4±0.5ms 78.5±0.6ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
366±3ms 365±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
84.4±1ms 84.7±2ms 1 benchmarks.Suite.time_paths_creation
125±1ms 124±0.4ms 0.99 benchmarks.time_test_alignment_even_sky
997±8μs 988±6μs 0.99 benchmarks.time_test_cone_filter_multiple_order
13.5±0.3ms 13.2±0.1ms 0.98 benchmarks.Suite.time_inner_pixel_alignment
20.6±0.3ms 19.7±0.1ms 0.96 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (3e1797c) to head (22cdc81).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   93.80%   93.92%   +0.11%     
==========================================
  Files          57       58       +1     
  Lines        2002     2057      +55     
==========================================
+ Hits         1878     1932      +54     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schwarzam Schwarzam requested a review from delucchi-cmu June 19, 2024 03:51
src/hipscat/io/file_io/file_io.py Show resolved Hide resolved
src/hipscat/io/file_io/file_io.py Outdated Show resolved Hide resolved
src/hipscat/io/file_io/__init__.py Outdated Show resolved Hide resolved
src/hipscat/io/file_io/file_io.py Outdated Show resolved Hide resolved
src/hipscat/io/file_io/file_io.py Outdated Show resolved Hide resolved
@Schwarzam Schwarzam force-pushed the pandas_storage_options branch from eba82ae to 22cdc81 Compare July 1, 2024 17:44
@Schwarzam Schwarzam requested a review from delucchi-cmu July 1, 2024 18:00
@nevencaplar nevencaplar requested a review from smcguire-cmu July 5, 2024 22:31
@nevencaplar
Copy link
Member

@smcguire-cmu Can you please review this pull while Melissa is away.

Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution!

@Schwarzam Schwarzam merged commit c081ede into main Jul 12, 2024
12 checks passed
@Schwarzam Schwarzam deleted the pandas_storage_options branch July 12, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent handling of headers in storage_options for pandas read methods
4 participants