Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage options to more catalog calls #244

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Mar 21, 2024

Change Description

Closes #240

Related to astronomy-commons/lsdb#103

Solution Description

Optionally passes along a storage_options dictionary.

Also, addresses issues with direct read of parquet datasets from remote storage.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (deffbb2) to head (34ecc45).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          57       57           
  Lines        1992     1995    +3     
=======================================
+ Hits         1991     1994    +3     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [deffbb2] After [23efe04] Ratio Benchmark (Parameter)
78.6±0.2ms 79.3±0.4ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
79.1±0.2ms 79.4±0.6ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
641±10ms 643±3ms 1 benchmarks.Suite.time_pixel_tree_creation
124±0.9ms 124±0.3ms 1 benchmarks.time_test_alignment_even_sky
96.1±0.7ms 96.5±1ms 1 benchmarks.time_test_cone_filter_multiple_order
19.8±0.5ms 19.7±0.2ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@delucchi-cmu delucchi-cmu merged commit bf275bc into main Mar 21, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/index_cloud branch March 21, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading index catalog with URI fails
2 participants