Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for polygon degeneracy #195

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

camposandro
Copy link
Contributor

Adds some additional validation to the catalog search using polygons. In particular, this change makes sure that polygons provided by the user are not degenerate, preventing some invalid calls to healpy's query_polygon. This is part of issue astronomy-commons/lsdb#120.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d001db3) 99.72% compared to head (f3e559d) 99.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          53       53           
  Lines        1792     1811   +19     
=======================================
+ Hits         1787     1806   +19     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [d001db3] After [a066499] Ratio Benchmark (Parameter)
1.12±0.01s 1.13±0s 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
1.83±0.01s 1.84±0.01s 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
312±9ms 312±10ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
653±7ms 646±5ms 0.99 benchmarks.Suite.time_pixel_tree_creation
124±0.7ms 123±0.5ms 0.99 benchmarks.time_test_alignment_even_sky
98.7±2ms 97.2±0.7ms 0.98 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@camposandro camposandro merged commit 3358fbc into main Jan 18, 2024
11 checks passed
@camposandro camposandro deleted the sandro/check-polygon-degeneracy branch January 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants