Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept lists of coordinates for polygonal search #187

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

camposandro
Copy link
Contributor

It removes the need for the spherical-geometry dependency on hipscat, as part of the migration to the sphgeomlibrary. It also changes the interface to accept as input the lists of vertices instead of a pre-instantiated polygon object. Relates to astronomy-commons/lsdb#84. Closes #177.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Dec 21, 2023
@camposandro camposandro changed the title Use sphgeom for polygonal search Accept lists of coordinates for polygonal search Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62b1286) 99.71% compared to head (e49c0ba) 99.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          51       51           
  Lines        1741     1744    +3     
=======================================
+ Hits         1736     1739    +3     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [62b1286] After [85923e5] Ratio Benchmark (Parameter)
285±20ms 306±20ms 1.07 benchmarks.MetadataSuite.time_load_partition_info_order6
645±7ms 653±10ms 1.01 benchmarks.Suite.time_pixel_tree_creation
1.14±0.01s 1.14±0.01s 1 benchmarks.MetadataSuite.time_load_partition_info_order7
1.86±0.01s 1.86±0.02s 1 benchmarks.MetadataSuite.time_load_partition_join_info
124±0.8ms 123±0.4ms 1 benchmarks.time_test_alignment_even_sky
98.4±0.9ms 96.8±0.6ms 0.98 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't expecting this PR to remove code/calls! Nice!

@camposandro camposandro merged commit 50c6e80 into main Dec 22, 2023
10 checks passed
@camposandro camposandro deleted the issue/84/add-sphgeom branch December 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow input coordinates in the polygon filtering call
3 participants